Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to design-system 0.32.0 #8004

Closed
wants to merge 1 commit into from

Conversation

billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Nov 3, 2023

TODO:

  • The filter tags on the blog page, after the style changes to the tag in #1777, makes the "X" closing button move to a second line underneath the "Data, research, and reports" filter tag at full desktop viewport width (at least with my setup). It looks a little weird, so was wondering if we wanted to change that?
Currently on cf.gov (DS 0.31.0) On local (DS 0.32.0)
tag-change-after-1 tag-change-before-1
  • What should I do about the Snyk warnings? Recent commits look like they ignored these errors, but I wanted to make sure. I also don't have access to see what's failing, but have requested access via Snyk's UI.
  • Testing on IE, Edge, and Android (on actual hardware, not just dev tools)? This might be tricky unless someone grants me access to push these changes to one of the dev environments, which I've only heard about? I don't know if this browser testing is usually done for these DS updates, but I wanted to make sure I was extra thorough for this first update.

Changes

  • Update deps: design-system 0.32.0 (2023-10-24)

Breaking

  • cfpb-core
    • #1785 fix: [Lead paragraph] Adjust margins

Bug Fix

  • cfpb-buttons, cfpb-core, cfpb-layout, cfpb-notifications, cfpb-pagination, cfpb-tables, cfpb-typography
    • #1789 Remove redundant margin | add responsive style code comments

Enhancement

  • cfpb-layout
    • #1781 New component: o-text-introduction
  • cfpb-forms
    • #1777 [Tag] Update styles per approved redesign

How to test this PR

  1. Does updating the design-system dependency cause any unintended consequences for the cf.gov styling or functionality? (see screenshot comparisons below)

Screenshots

#1785 fix: [Lead paragraph] Adjust margins (desktop)

Currently on cf.gov (DS 0.31.0) On local (DS 0.32.0)
margin-before margin-after

#1789 Remove redundant margin | add responsive style code comments (mobile)

Currently on cf.gov (DS 0.31.0) On local (DS 0.32.0)
before-lead-para-margin-mobile after-lead-para-margin-mobile

#1781 New component: o-text-introduction
currently only used in the design system

#1777 [Tag] Update styles per approved redesign
NOTE: Tag length on Blog now makes the "X" closing button move to a second line underneath "Data, research, and reports" filter tag at full desktop viewport width (at least with my setup). It looks a little weird, so was wondering if we wanted to change that?

Currently on cf.gov (DS 0.31.0) On local (DS 0.32.0)
tag-change-after-1 tag-change-before-1

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines
  • Future todos are captured in comments and/or tickets
  • Project documentation has been updated, potentially one or more of:
    • This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
    • CFGOV/platform wiki on GHE – for internal CFPB developer guidance
    • CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Front-end testing

Browser testing

Visually tested in the following supported browsers:

  • Firefox
  • Chrome
  • Safari I noticed a bug with the category dropdown on the blog site on Safari, but it's not a new issue and I believe may be addressed by Multiselect: Remove display: -webkit-box property design-system#1792 in a future DS release
  • Edge 18 (the last Edge prior to it switching to Chromium)
  • Internet Explorer 11 and 8 (via emulation in 11's dev tools)
  • Safari on iOS
  • Chrome on Android

Accessibility

  • Does not introduce new errors or warnings in WAVE

Other

  • Does not introduce new lint warnings
  • Flexible from small to large screens

@anselmbradford
Copy link
Member

Makes the "X" closing button move to a second line underneath the "Data, research, and reports" filter tag at full desktop viewport width (at least with my setup). It looks a little weird, so was wondering if we wanted to change that?

Yeah this jumped out to me as well. We'd want to fix this.

@anselmbradford
Copy link
Member

What should I do about the Snyk warnings? Recent commits look like they ignored these errors, but I wanted to make sure. I also don't have access to see what's failing, but have requested access via Snyk's UI.

Mentioned in chat, can be ignored.

Testing on IE, Edge, and Android (on actual hardware, not just dev tools)? This might be tricky unless someone grants me access to push these changes to one of the dev environments, which I've only heard about? I don't know if this browser testing is usually done for these DS updates, but I wanted to make sure I was extra thorough for this first update.

Mentioned in chat, tools are available.

@billhimmelsbach billhimmelsbach mentioned this pull request Nov 8, 2023
13 tasks
@anselmbradford
Copy link
Member

Superseded by #8009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants